On Thu, Nov 05, 2009 at 06:07:54PM +0100, Paolo Bonzini wrote:
On 11/05/2009 06:04 PM, Daniel Veillard wrote:
+static int ATTRIBUTE_SENTINEL ebtablesAddRemoveRule(ebtRules *rules, int action, const char *arg, ...) { I'm just surprized by having the __attribute__ being inserted before the function name, I would expect to have it between the end of the arguments ) and the curly brace { for this to work correctly.
For prototypes you can place it in either position, but in this case we have no prototype so you have to place it there. I wasn't sure either, so I did try triggering it and it works in both cases.
Okay, I checked too, and it just doesn't compile if added the way I expected, trange it's fine for forward declaration, but breaks in implementations. No big deal :-) I just added ATTRIBUTE_SENTINEL to docs/apibuild.py list of ignored words because I'm sure it would break next time we try to generate the API. Commited and pushed :-) thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/