Re: [libvirt] [PATCHv2 2/2] qemu: increase the timeout before sending SIGKILL to qemu process

On 02/03/2012 10:06 AM, Eric Blake wrote: Hmm, I've just had a second thought. Looking back at this thread that never got applied because Dan had some review comments where I did not have time to implement them: https://www.redhat.com/archives/libvir-list/2011-November/msg00243.html Right now, we guarantee that we will timeout in 3 seconds, but during those three seconds, we hold the driver lock, which means that no other application can issue any command on any other VM managed by the same connection. If we are going to lengthen the timeout, then we also need to start thinking about dropping the driver lock for the duration of the wait - that is, operations on the VM being destroyed will be blocked (except for parallel attempts to destroy the same domain), but operations on other domains should not be blocked by the longer timeout. Even if we don't resolve Dan's concern of subdividing the driver lock into more manageable pieces, we should at least resolve the problem of holding the driver lock for the entire virDomainDestroy operation, before we lengthen the timeouts involved. -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org