Re: [libvirt] [RFC: PATCH 2/2] viruri: add more tests
On Fri, Mar 23, 2012 at 04:09:59PM -0600, Eric Blake wrote:
When qparams support was dropped in commit bc1ff160, we forgot
to add tests to ensure that viruri can do the same round trip
handling of a URI.
Also, we forgot to report an OOM error.
NOTE: THIS TEST CURRENTLY FAILS ON ANY QUERY WITH % ESCAPING.
This is due to mistaken use of the old 'query' field instead
of 'query_raw'. The former has broken escape handliing. I pushed
your patch with the following added
@@ -243,15 +243,21 @@ virURIFormat(virURIPtr uri)
xmluri.server = uri->server;
xmluri.port = uri->port;
xmluri.path = uri->path;
+#ifdef HAVE_XMLURI_QUERY_RAW
+ xmluri.query_raw = uri->query;
+#else
xmluri.query = uri->query;
+#endif
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|