Re: [libvirt] [PATCH 1/5] logging: allow inode/offset params to be NULL

On 02/23/2016 11:41 AM, Daniel P. Berrange wrote:

Not all callers of virLogManagerDomainOpenLogFile will care about getting the current inode/offset, so we should allow those parameters to be NULL

Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/logging/log_manager.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)

In retrospect, probably could have used ATTRIBUTE_NONNULL on these args previously... ACK John