On 10/24/2014 10:17 AM, Shanzhi Yu wrote:
if (networkDriver && virRegisterNetworkDriver(networkDriver) < 0)
ACK to this.
Or did you botch the logic, and really mean:
if (!networkDriver || virRegisterNetworkDriver(networkDriver) < 0)
Furthermore, Dan's recent patch series will probably overhaul all of this anyways, so it may be easier to just wait for his patches to land.
Thanks for your review. I mean the && not ||.
No, the logic in the patch is correct. We don't want an error if the networkDriver is NULL. We just want to continue running without any error in that case.
We should push this now because we'll want to cherry pick it to stable branches.
Pushed with some minor grammar tweaks to the commit message. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org