On Sat, May 19, 2018 at 08:31:50 -0500, Chris Venteicher wrote:
Most of the comments make immediate sense. The rest I will need a few days in the code to dig deeper to understand.
Jirka, - Looks like S390 support for baseline / compare still needs to be added to your "new cpu related apis". (Exchanging QMP messages so QEMU can do the baseline / compare operation.) The baseline patches I am working on should add S390 support to your new cpu related apis.
Yes, the s390 code would just fit in a new "else if (ARCH_IS_S390(arch))" branch in qemuConnectCompareHypervisorCPU.
- Looks like S390 support should still be added to virsh cpu-baseline (and cpu-compare) but there are dependencies on the changes made in the "new cpu related apis" patch set.
No, the old APIs won't get any support for s390. Jirka