Re: [libvirt] [PATCH V1 1/9] Add support for VLAN filtering
On Tue, Nov 15, 2011 at 05:46:21PM -0700, Eric Blake wrote:
On 10/26/2011 09:11 AM, Stefan Berger wrote:
Apologies for delaying so long on reviewing this.
> This patch adds support for filtering of VLAN (802.1Q) traffic to the
> parser and makes us of the ebtables support for VLAN filtering. This code
> now enables the filtering of traffic in chains with prefix 'vlan'.
>
> Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com>
>
> ---
> docs/schemas/nwfilter.rng | 47 +++++++++++++
> src/conf/nwfilter_conf.c | 102 ++++++++++++++++++++++++++++++
> src/conf/nwfilter_conf.h | 17 +++++
> src/nwfilter/nwfilter_ebiptables_driver.c | 35 ++++++++++
> 4 files changed, 201 insertions(+)
>
This didn't apply cleanly for me. Am I missing the review of another
pre-requisite series? Or is it just something where you need to rebase
and post a v2 for easier review?
It could be some of my netdev API renaming invalidated it ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|