Re: [libvirt] [PATCH 2/2] virsh-domain: Report errors on invalid --holdtime value for cmdSendKey

On 04/18/2013 02:51 AM, Peter Krempa wrote:

Using of a incorrect value for the --holdtime option was silently ignored and 0 was used. In case a negative number was used, it overflowed as the API expects a unsigned int.

Fix the data type and getter function type and report errors on incorrect values. --- tools/virsh-domain.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)

ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org