Re: [libvirt PATCH] rpm: merge mingw sub-packages into native spec
On Mon, Aug 08, 2022 at 01:22:17PM -0400, Daniel P. Berrangé wrote:
One specfile containing both native and mingw builds is the
new best practice for Fedora. This reduces the maint burden
and ensures the mingw packages don't fall behind.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
.gitlab-ci.yml | 2 +-
libvirt.spec.in | 287 ++++++++++++++++++++++++++++++++++++
meson.build | 17 +--
mingw-libvirt.spec.in | 327 ------------------------------------------
4 files changed, 293 insertions(+), 340 deletions(-)
delete mode 100644 mingw-libvirt.spec.in
The patch looks good but there are some changes not mentioned directly.
With this patch we will build MinGW packages by default on Fedora. Not
sure if that is desirable. I would rather have it the other way around
if it works for Fedora best practice.
We also lose the ability to build only MinGW packages but I don't think
that's a big deal.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)