RE: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu
-----Original Message-----
From: Richard Henderson [mailto:richard.henderson@linaro.org]
Sent: Sunday, November 21, 2021 6:19 AM
To: Jiangyifei <jiangyifei(a)huawei.com>; qemu-devel(a)nongnu.org;
qemu-riscv(a)nongnu.org
Cc: bin.meng(a)windriver.com; limingwang (A) <limingwang(a)huawei.com>;
kvm(a)vger.kernel.org; libvir-list(a)redhat.com; anup.patel(a)wdc.com; wanbo (G)
<wanbo13(a)huawei.com>; Alistair Francis <alistair.francis(a)wdc.com>;
kvm-riscv(a)lists.infradead.org; Wanghaibin (D)
<wanghaibin.wang(a)huawei.com>; palmer(a)dabbelt.com; Fanliang (EulerOS)
<fanliang(a)huawei.com>; Wubin (H) <wu.wubin(a)huawei.com>
Subject: Re: [PATCH v1 03/12] target/riscv: Implement function
kvm_arch_init_vcpu
On 11/20/21 8:46 AM, Yifei Jiang wrote:
> + id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG,
KVM_REG_RISCV_CONFIG_REG(isa));
> + ret = kvm_get_one_reg(cs, id, &isa);
> + if (ret) {
> + return ret;
> + }
> + env->misa_mxl |= isa;
This doesn't look right.
I'm sure you meant
env->misa_ext = isa;
r~
Thanks, it will be modified in the next series.
Yifei