On Thu, Jun 21, 2012 at 12:42:17PM +0200, Bruno Haible wrote:
Daniel P. Berrange wrote:
Here's what i see in config.status for my libvirt build:
$ grep -i vscanf config.status S["GNULIB_VSCANF"]="0"
$ grep STDIO config.status S["NEXT_AS_FIRST_DIRECTIVE_STDIO_H"]="<stdio.h>" S["NEXT_STDIO_H"]="<stdio.h>" S["REPLACE_STDIO_WRITE_FUNCS"]="1" S["REPLACE_STDIO_READ_FUNCS"]="1" S["GNULIB_STDIO_H_SIGPIPE"]="1" S["GNULIB_STDIO_H_NONBLOCKING"]="1"
Thanks for these details. The attached patch looks like it should fix the compilation error. I'm committing it. Can you please try it (you need to re-bootstrap libvirt to this effect, I guess)?
2012-06-21 Bruno Haible <bruno@clisp.org>
nonblocking: Avoid compilation error on mingw64. * m4/stdio_h.m4 (gl_STDIO_H): Invoke gl_MODULE_INDICATOR for scanf, fscanf. * modules/vscanf (configure.ac): Invoke gl_MODULE_INDICATOR. * modules/vfscanf (configure.ac): Likewise. * lib/stdio-read.c (scanf, fscanf, vscanf, vfscanf): Enable function definition only if stdio.h has prepared it. Reported by Daniel P. Berrange <berrange@redhat.com>.
Thanks Bruno. I have confirmed that this patch plus the other 2 previously committed allow libvirt/gnulib to compile warning/error free with Mingw64. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|