On 08/20/2012 06:06 PM, Daniel P. Berrange wrote:
BZ RFE https://bugzilla.redhat.com/show_bug.cgi?id=795929 qemu support: http://git.qemu.org/?p=qemu.git;a=commitdiff;h=6af165892cf900291046f1d25f954...
Since qemu has have the code to support USB redirection filter. This set of patches try to support it from libvirt. The XML format is like this: <devices> ... <redirdev bus='usb' type='spicevmc'> <address type='usb' bus='0' port='4'/> </redirdev> <redirfilter> <usbdev class='0x08' vendor='0x1234' product='0xbeef' \ version='2.00' allow='yes'/> <usbdev class='-1' vendor='-1' product='-1' version='-1' allow='no'/> </redirfilter> ... </devices> I don't really see the point in this being done on the libvirt side. The <redirdev> code is allowing redirection of a USB device from a client (eg SPICE) app, to the remote QEMU instance and from there to
On Sun, Aug 19, 2012 at 11:42:43PM +0800, Guannan Ren wrote: the guest.
With this architecture, IMHO filtering of USB devices is something that belongs in the client app, not in QEMU which is a broker inbetween the client & guest OS.
So NACK to this whole series
Daniel
Thanks for this review. As far as I know, the spicy client doesn't have the filtering functionality. spicy client could work together with qemu which supports usb-redir.filter to filter usb devices. I really couldn't say anything about the architecture currently. So cc Hans who is the RFE requester. Guannan Ren