Re: [libvirt-jenkins-ci PATCH 7/7] lcitool: Create and expose ccache wrappers
On Mon, Mar 30, 2020 at 02:31:40PM +0200, Andrea Bolognani wrote:
On Mon, 2020-03-30 at 13:23 +0100, Daniel P. Berrangé wrote:
> On Mon, Mar 30, 2020 at 02:21:19PM +0200, Andrea Bolognani wrote:
> > We could still expose the path as something like
> >
> > ENV CCACHE_WRAPPERSDIR "/usr/local/share/ccache-wrappers"
> >
> > so that the CI rules would be able to do
> >
> > - export PATH="$CCACHE_WRAPPERSDIR:$PATH"
> >
> > instead of hardcoding the exact path. What do you think?
>
> Sure, works for me.
Cool! Can I have a Reviewed-by, then? O:-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|