Re: [libvirt] [PATCH] nwfilter: Extend fwall-drv interface and call functions via interface

On 04/18/2010 06:43 PM, Stefan Berger wrote:

I moving some functions into the interface of the firewall driver and make them only accessible via the driver's interface. Adapt the code

That first sentence reads awkwardly, if you want to touch it up before pushing.

where needed. One new function is added that checks whether some 'basic' rules can be applied, which is used by a subsequent patch.

Looks reasonable. ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org