On Tue, Jul 02, 2013 at 07:49:50AM -0600, Eric Blake wrote:
On 07/02/2013 03:43 AM, Daniel P. Berrange wrote:
On Mon, Jul 01, 2013 at 02:10:29PM -0600, Eric Blake wrote:
rpmbuild of mingw-libvirt.spec failed with:
GEN libvirt.syms GEN libvirt_qemu.def cat: libvirt_access.syms: No such file or directory cat: libvirt_access_qemu.syms: No such file or directory cat: libvirt_access_lxc.syms: No such file or directory
I traced this to unconditionally trying to use the ACL .syms files, even when polkit isn't in use.
Hmm, really ? The methods in these .syms files are actually methods that are inserted into all the driver method impls unconditionally. So we shouldn't make this conditional on polkit, rather we should fix the bug that causes them to be unused when polkit is missing.
I'll keep investigating, then. My next step will be to see if I can reproduce it on a --without-libvirtd local build, instead of being stuck with debugging mingw cross-compiling.
Oh, is it a race condition in generating the .def file. The libvirt_access*.sym files are all auto-generated files. The .def file is also auto-generated, and there is no dep from the .def file onto the libvirt_acces*sym files to control execution order. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|