On Fri, May 07, 2021 at 01:22:13PM +0200, Peter Krempa wrote:
On Tue, May 04, 2021 at 18:16:12 +0200, Kashyap Chamarthy wrote:
[...]
diff --git a/docs/kbase/live_full_disk_backup.rst b/docs/kbase/live_full_disk_backup.rst new file mode 100644 index 0000000000..f4ef7f2cc7 --- /dev/null +++ b/docs/kbase/live_full_disk_backup.rst @@ -0,0 +1,111 @@ +Efficient live full disk backup +===============================
It feels nowadays a bit weird to add a document which outlines everything you can achieve with the virDomainBackupBegin API without any of the extra steps.
Right, I wrote them when virDomainBackupBegin() and friends were not there yet :-). I see that the newer API is mentioned in the "internals" doc here, which outlines how libvirt implements incremental backups and some "pseudo algorithms" on external snapshots: https://libvirt.org/kbase/incrementalbackupinternals.html
I'd suggest you note that this predates the backup APIs or link to them somehow.
Yep, I'll mention and link to it. But also I think a separate, use-case drive doc for virDomainBackupBegin() and friends can also be very handy. I'll make that a TODO after I clean-up these two first. [...] -- /kashyap