On Tue, Aug 28, 2018 at 02:24:42PM +0200, Ján Tomko wrote:
On Tue, Aug 28, 2018 at 02:10:55PM +0200, Erik Skultety wrote:
On Tue, Aug 28, 2018 at 11:35:02AM +0100, Daniel P. Berrangé wrote:
On Mon, Aug 27, 2018 at 05:50:22PM +0200, Simon Kobyda wrote:
On Fri, 2018-08-24 at 12:10 +0200, Michal Privoznik wrote:
On 08/24/2018 11:36 AM, Daniel P. Berrangé wrote:
On Fri, Aug 24, 2018 at 10:59:04AM +0200, Michal Privoznik wrote:
But first fix the build failures :-)
On CentOS / RHEL:
https://travis-ci.org/libvirt/libvirt/jobs/420024141
4) testUnicode . .. Offset 30 Expect [государство ----------------------------------------- 1 fedora28 running 2 🙊🙉🙈rhel7.5🙆🙆🙅] Actual [ государство ----------------------------------------------------------------- ------------------------------------------------------------ 1 fedora28 running 2 \xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xffrhel7.5\xff\x ff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff]
Okay, this is probably due to ancient gcc that's there (4.8.0) and is supposed to be fixed by adding -finput-charset= onto gcc command line. Haven't tested it though.
I tried but it didn't help. From what I understood, CentOS has problems with unicodes such as 🙊🙉🙈🙆🙆🙅. On that system, it can convert any of those characters to wchar_t successfully and properly, but when we pass that character to iswprint, it returns 0 (considers those wide characters nonprintable).
On the plus side, it appears that when this problem hits, the code is still correctly doing the column alignment taking account of these unexpected escape sequences.
So how about storing 2 sets of expected data for this test case.
Two is not enough. My clang 5.0.1 produces a test that displays the monkeys correctly, but does not count their width properly:
Is this a different bug though ? The issue with iswprint() is varying according to glibc version, not compiler version. So I wonder if the clang problem you mention is something that can be fixed in some way ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|