On 09.06.2016 16:46, Jim Fehlig wrote:
This is essentially a V2 of
https://www.redhat.com/archives/libvir-list/2016-April/msg01358.html
To avoid code duplication in that series, I proposed adding a virFirmware object that could be used by multiple drivers
https://www.redhat.com/archives/libvir-list/2016-May/msg01370.html
mprivozn ACK'ed that series, but I deferred committing it until 1.3.5 was released since it's not all that useful without accompanying use by another driver. This series includes all the patches rebased and tested against latest git master.
Note: I sent this series yesterday, but int-mx.corp.redhat.com rejected 0/6 and 3/6 with "550 5.1.1 <libvir-list redhat com>... User unknown (in reply to RCPT TO command)". I'm resending in hopes that all patches make it through this time.
Jim Fehlig (6): driver config: Introduce virFirmware object libxl: add default firmwares to driver config object libxl: introduce libxl_capabilities.{ch} libxl: implement connectGetDomainCapabilities xenconfig: support bios=ovmf xl.cfg libxl: Add support for ovmf firmware
po/POTFILES.in | 2 + src/Makefile.am | 12 +- src/libvirt_private.syms | 6 + src/libxl/libxl_capabilities.c | 598 +++++++++++++++++++++ src/libxl/libxl_capabilities.h | 57 ++ src/libxl/libxl_conf.c | 448 +-------------- src/libxl/libxl_conf.h | 22 +- src/libxl/libxl_domain.c | 1 + src/libxl/libxl_driver.c | 75 +++ src/qemu/qemu_capabilities.c | 22 +- src/qemu/qemu_capabilities.h | 5 +- src/qemu/qemu_conf.c | 127 +---- src/qemu/qemu_conf.h | 7 +- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 6 +- src/util/virfirmware.c | 137 +++++ src/util/virfirmware.h | 51 ++ src/xenconfig/xen_xl.c | 50 +- tests/Makefile.am | 5 + tests/domaincapsschemadata/libxl-xenfv.xml | 68 +++ tests/domaincapsschemadata/libxl-xenpv.xml | 58 ++ tests/domaincapstest.c | 64 ++- tests/testutilsxen.h | 1 + tests/xlconfigdata/test-fullvirt-ovmf-override.cfg | 27 + tests/xlconfigdata/test-fullvirt-ovmf-override.xml | 58 ++ tests/xlconfigdata/test-fullvirt-ovmf.cfg | 26 + tests/xlconfigdata/test-fullvirt-ovmf.xml | 58 ++ tests/xlconfigtest.c | 2 + 28 files changed, 1417 insertions(+), 578 deletions(-) create mode 100644 src/libxl/libxl_capabilities.c create mode 100644 src/libxl/libxl_capabilities.h create mode 100644 src/util/virfirmware.c create mode 100644 src/util/virfirmware.h create mode 100644 tests/domaincapsschemadata/libxl-xenfv.xml create mode 100644 tests/domaincapsschemadata/libxl-xenpv.xml create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf-override.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf-override.xml create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.xml
I'd ACK this as it looks very good. But there's small problem in 5/6 we should fix before pushing this. Michal