Re: [libvirt] [PATCH 10/10] conf: Add and export wrapper for parsing storage source XML

On Wed, Mar 14, 2018 at 11:00:46 +0100, Michal Privoznik wrote: > On 03/13/2018 03:37 PM, Peter Krempa wrote: >> Add a helper that parses a storage source XML node into a new >> virStorageSource object. Since there are multiple approaches to store >> the 'type' and 'format' attributes, they need to be parsed manually >> prior to calling the function. >> >> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; >> --- >> src/conf/domain_conf.c | 60 ++++++++++++++++++++++++++++++++++++++++++++++++ >> src/conf/domain_conf.h | 6 +++++ >> src/libvirt_private.syms | 1 + >> 3 files changed, 67 insertions(+) > > Perhaps you forgot to include next patch that uses > virDomainStorageSourceParseNew()? Because this patch does nothing more > than introducing a function that is never used. Yes. The patch that uses this function was not posted yet. I'm sending these sub-series out so that I don't have to send 50+ patches at once.