On Fri, Nov 15, 2019 at 04:51:46PM +0100, Peter Krempa wrote:
To avoid using -drive as much as possible convert PFLASH to use -blockdev as well.
Since -blockdev is not enabled yet use the following qemu namespace XML override to enable it for testing:
<domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> ... <qemu:capabilities> <qemu:add capability='blockdev'/> </qemu:capabilities> </domain>
Peter Krempa (6): qemu: command: Extract formatting of -drive for pflash qemu: domain: Store virStorageSources representing pflash backing qemu: domain: Introduce helper to convert <loader> into virStorageSource qemu: command: Build -blockdev-s for backing of pflash qemu: command: Build the 'pflash' drives via -machine qemu: Instantiate pflash via -machine when using blockdev
src/qemu/qemu_command.c | 136 ++++++++++++++++++++++++++++++---------- src/qemu/qemu_domain.c | 63 +++++++++++++++++++ src/qemu/qemu_domain.h | 9 +++ src/qemu/qemu_process.c | 6 ++ 4 files changed, 180 insertions(+), 34 deletions(-)
There ought to be a file added to qemuxml2argvtest to validate the new -blockdev syntax for pflash. Maybe you have it further down in your queue of pending blockdev patches ? If not just send a followup to add a test, no need to repost this whole series. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|