Re: [libvirt] [PATCH] conf: Make scheduler formatting simpler

On 11/22/2016 08:53 AM, Martin Kletzander wrote: > Since the great rework of how we store vcpu- and iothread-related > data, we have overly complex part of code that is trying to format the > scheduler tuning data in as less lines as possible by grouping > settings for multiple threads. That was designed as an input syntax > sugar for users, but we don't need to also use that when formatting > the XML. Switching to simple enumeration makes the code nicer, > shorter and more welcoming to future changes. > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > src/conf/domain_conf.c | 209 ++++----------------- > ...l2xmlout-cputune-iothreadsched-zeropriority.xml | 7 +- > .../qemuxml2xmlout-cputune-iothreadsched.xml | 7 +- > 3 files changed, 43 insertions(+), 180 deletions(-) > Yes it certainly does make it easier to read... One suggestion - change the name of the function to "virDomainSchedulerFormat" since it makes it easier to find virDomainSchedulerParse ACK

John