Re: [libvirt] [PATCH 04/20] test: Implement virConnectSupportsFeature

On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Implement virConnectSupportsFeature for the test driver as this API is > used by various API functions (the functions usually use the macro > VIR_DRV_SUPPORTS_FEATURE for calling virConnectSupportsFeature). > > Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com&gt; > Reviewed-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com&gt; > Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com&gt; > --- > src/test/test_driver.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index 043caa976274..203358c7017f 100644 > --- a/src/test/test_driver.c > +++ b/src/test/test_driver.c > @@ -6829,6 +6829,32 @@ testDomainRevertToSnapshot(virDomainSnapshotPtr snapshot, > } > > > +static int > +testConnectSupportsFeature(virConnectPtr conn ATTRIBUTE_UNUSED, > + int feature) > +{ > + switch ((virDrvFeature) feature) { > + case VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK: > + return 1; Not that it makes a difference, but since src/remote/remote_daemon_dispatch.c returns 1 for VIR_DRV_FEATURE_REMOTE_EVENT_CALLBACK always like VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK used to before patch 2, then does returning 1 here really matter? Perhaps why Nikolay added to remoteDispatchConnectSupportsFeature since commit id '03722957' was the last to add some new feature bit... [yes, I'm still a bit mystified about how all this works - so I'm learning a bit as I go... Still not clear why the same API returns 1 for VIR_DRV_FEATURE_FD_PASSING always].