Re: [libvirt] [PATCH v2] tests: Add more complex domain scheme test data

On 05/31/2011 08:59 AM, Michal Privoznik wrote: > --- > diff to v1: > -move from tests/domainschemadata/ to tests/qemuxml2argvdata/ > -add .args > > .../qemuxml2argv-graphics-spice-timeout.args | 14 +++ > .../qemuxml2argv-graphics-spice-timeout.xml | 86 ++++++++++++++++++++ > tests/qemuxml2argvtest.c | 5 + > tests/qemuxml2xmltest.c | 3 +- > 4 files changed, 107 insertions(+), 1 deletions(-) > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args > create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.xml > > diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args > new file mode 100644 > index 0000000..7c30e43 > --- /dev/null > +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-timeout.args > @@ -0,0 +1,14 @@ > +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=spice \ > +/usr/bin/qemu-kvm -S -M pc-0.13 -cpu core2duo,+lahf_lm,+xtpr,+cx16,+tm2,+est,+vmx,+ds_cpl,+pbe,+tm,+ht,+ss,+acpi,+ds \ You can additionally add backslash-newline pairs in the middle of this line, rather than only breaking lines after spaces, if it helps fit the file into 80 columns. But that's stylistic, and not a showstopper to have a long line. So ACK.