Re: [sdl-qemu] [PATCH 0/1] There are no checks, virDomainChrSourceDefNew can return 0

Okay, Peter Should I resend the patches correctly or wait for a response for those added to the mailing list? https://listman.redhat.com/archives/libvir-list/2023-September/242078.html https://listman.redhat.com/archives/libvir-list/2023-September/242077.html ________________________________ От: Peter Krempa <pkrempa(a)redhat.com&gt; Отправлено: 14 сентября 2023 г. 13:17 Кому: Миронов Сергей Владимирович Копия: libvirt-security(a)redhat.com; qemu-devel(a)nongnu.org; libvir-list(a)redhat.com; sdl.qemu(a)linuxtesting.org Тема: Re: [sdl-qemu] [PATCH 0/1] There are no checks, virDomainChrSourceDefNew can return 0 CC-ing qemu-devel with a patch solely for libvirt doesn't make sense. Also 'libvirt-security' list is private and is is intended as a first contact list for stuff to be embargoed. It makes little sense to include it when posting to the public 'libvir-list'. On Thu, Sep 14, 2023 at 09:44:13 +0000, Миронов Сергей Владимирович wrote: s/0/NULL While very technically true, realistically that can't happen any more. 'virObjectNew' always returns a valid pointer or abort()s, and VIR_CLASS_NEW can return 0 on programming errors. Thus this is not a security issue. Remove the extra empty lines please. ^^ This makes no sense. The commit you are referencing is changing a shell script.