Re: [libvirt] [PATCH 06/12] tests: qemuxml2argv: Rename testInfo* to testQemuInfo*
On Mon, 2019-04-01 at 12:47 -0400, Cole Robinson wrote:
In preparation for moving these bits to a shared place, rename them
to match one of the testqemuutils.c function prefixes. Rename
s/testqemuutils/testutilsqemu/
[...]
static int
-testCheckExclusiveFlags(int flags)
+testQemuInfoCheckExclusiveFlags(int flags)
According to the logic used in the commit message to justify not
renaming testInfoSetPaths(), this one should either keep its name as
well or be moved to testutilsqemu. I would go for the former right
now, but it would be neat if you explored whether calling it from
xml2xml too would make sense, for a follow-up patch.
Everything else looks good, so assuming that you don't rename the
function
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization