Re: [libvirt] [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr

Looks OK Best, Maxim Nestratov ________________________________ От: Dmitry Guryanov<mailto:dguryanov@parallels.com> Отправлено: ‎10.‎12.‎2014 17:30 Кому: libvir-list@redhat.com<mailto:libvir-list@redhat.com> Копия: Alexander Burluka<mailto:mipt-aburluka@parallels.com>; Maxim Nestratov<mailto:mnestratov@parallels.com>; Dmitry Guryanov<mailto:dguryanov@parallels.com> Тема: [PATCH 1/3] parallels: support NULL virDomainVideoAccelDefPtr I support if virDomainVideoAccelDefPtr is NULL it means default values for video acceleration. So we don't need to report error. Signed-off-by: Dmitry Guryanov <dguryanov(a)parallels.com&gt; --- src/parallels/parallels_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/parallels/parallels_sdk.c b/src/parallels/parallels_sdk.c index 0b05bc1..0980f50 100644 --- a/src/parallels/parallels_sdk.c +++ b/src/parallels/parallels_sdk.c @@ -2029,7 +2029,7 @@ static int prlsdkCheckVideoUnsupportedParams(virDomainDefPtr def) return -1; } - if (v->accel == NULL || v->accel->support2d || v->accel->support3d) { + if (v->accel != NULL && (v->accel->support2d || v->accel->support3d)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Parallels Cloud Server doesn't support " "setting video acceleration parameters.")); -- 1.9.3