Re: [libvirt] [PATCH v4 5/9] Implement public API for getting/setting specific IOThread pinning

On 03/06/2015 04:46 AM, Daniel P. Berrange wrote: > On Thu, Mar 05, 2015 at 09:03:02PM -0500, John Ferlan wrote: >> Add virDomainGetIOThreadPin to fetch the pinned CPU affinity map >> for one IOThread. >> >> Add virDomainPinIOThread to allow setting the CPU affinity for a >> specific IOThread. >> >> Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; >> --- >> include/libvirt/libvirt-domain.h | 10 +++ >> src/driver-hypervisor.h | 16 +++++ >> src/libvirt-domain.c | 152 +++++++++++++++++++++++++++++++++++++++ >> src/libvirt_public.syms | 2 + >> 4 files changed, 180 insertions(+) >> >> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h >> index 9487b80..fc35cd2 100644 >> --- a/include/libvirt/libvirt-domain.h >> +++ b/include/libvirt/libvirt-domain.h >> @@ -1609,6 +1609,16 @@ void virDomainIOThreadsInfoFree(virDomainIOThreadInfoPtr info); >> int virDomainGetIOThreadsInfo(virDomainPtr domain, >> virDomainIOThreadInfoPtr **info, >> unsigned int flags); >> +int virDomainGetIOThreadPin (virDomainPtr domain, >> + unsigned int iothread_id, >> + unsigned char *cpumap, >> + int maplen, >> + unsigned int flags); > > Isn't the GetIOThreadsInfo method & struct already reporting the pinning > info for all current IO threads ? I'm not sure what the difference is > between what GetIOThreadsInfo and GetIOThreadPin is ? > > +struct _virDomainIOThreadInfo { > + unsigned int iothread_id; /* IOThread ID */ > + unsigned char *cpumap; /* CPU map for thread. A pointer to an */ > + /* array of real CPUs (in 8-bit bytes) */ > + int cpumaplen; /* cpumap size */ > +}; > > These fields match all the parameters in GetIOThreadPin, so it seems adding a > GetIOThreadPin is redundant, > > Yes - although based on reviews from yesterday it wasn't totally clear if having a GetIOThreadPin in addition to GetIOThreadsInfo was requested, so I added it to be "safe", but can remove it. There is a GetVcpus and a GetVcpuPinInfo and the IOThreads code mirrors that.