On Fri, Sep 20, 2019 at 1:28 PM Fabiano Fidêncio <fidencio@redhat.com> wrote:
On Fri, Sep 20, 2019 at 11:05 AM Pavel Hrdina <phrdina@redhat.com> wrote:
Meson build system is simple and quick compared to Autotools and it's able to fully replace our Autotools usage. There are few drawbacks as it's a fairly new build system, it requires Python 3.5 and Ninja 1.5.0, it's still evolving and the user base is not that large and there were some tweaks required to achieve the same functionality.
However, there are benefits, the configure and build time is way shorter and build definition files are more readable and easier to maintain.
There are some major changes with Meson build system:
- there is no syntax-check target, the syntax-check is part of Meson test suite but it's still possible to run it separately,
- Meson forces separation between source and build directories
Signed-off-by: Pavel Hrdina <phrdina@redhat.com> Tested-by: Ján Tomko <jtomko@redhat.com> ---
Notes: changes in v2:
- add -Werror if we are building from git - fixed -Wframe-larger-than - removed unrelated fix - added comment for flake8 ignore warning - added 'suite' labels 'syntax' and 'unit' for tests - AUTHORS and libvirt-dbus.spec are generated only when building from git
Why? Not opposed to this decision, just want to understand the reason for that.
- run.in is no longer executable, there is a helper script to fix permissions for the generated run script - fixed include_directories for test executable, direct paths can be used since meson 0.50.0
By using 0.50.0 you're dropping support on: - Debian 10; - Ubuntu 19.04;
Personally, I would stick to 0.49.0.
So, let me see if I properly understood your comment. You mean that before you were requiring 0.50.0 and now, because you changed the way to deal with the include_directories, you require 0.49.0. Is it? If so, just ignore my comment in the previous email. Best Regards, -- Fabiano Fidêncio