"Daniel P. Berrange" <berrange@redhat.com> wrote on 05/11/2010 06:25:05 AM:

>
> Also, when we have 2 different sets of attributes, we normally use
> a type attribute on the element to tell the parser what set of
> data to expect. So I think this should gain a 'type' attribute here.

Like these here

    <interface type='direct'>
      <source dev='static' mode='vepa'/>
      <model type='virtio'/>
      <vsi type='802.1Qbg' managerid='12' typeid='0x123456' typeidversion='1'
          instanceid='fa9b7fff-b0a0-4893-8e0e-beef4ff18f8f' />
      <filterref filter='clean-traffic'/>
   </interface>

   <interface type='direct'>
     <source dev='static' mode='vepa'/>
     <model type='virtio'/>
     <vsi type='802.1Qbh' profileid='my_profile'/>
   </interface>

or more like this

    <interface type='direct'>
      <source dev='static' mode='vepa'/>
      <model type='virtio'/>
      <vsi type='802.1Qbg'>
          <parameters managerid='12' typeid='0x123456' typeidversion='1'
           instanceid='fa9b7fff-b0a0-4893-8e0e-beef4ff18f8f' />
       </vsi>
      <filterref filter='clean-traffic'/>
   </interface>

?

   Stefan