On 05.11.2012 14:21, Christophe Fergeau wrote:
GVirObjectStream::finalize() logs a critical() if virStreamFinish fails. This commit adds the libvirt error message to this critical to ease debugging. --- libvirt-gobject/libvirt-gobject-stream.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libvirt-gobject/libvirt-gobject-stream.c b/libvirt-gobject/libvirt-gobject-stream.c index fa1a32c..3c61fdb 100644 --- a/libvirt-gobject/libvirt-gobject-stream.c +++ b/libvirt-gobject/libvirt-gobject-stream.c @@ -217,8 +217,10 @@ static void gvir_stream_finalize(GObject *object) if (priv->handle) { gvir_stream_update_events(self);
- if (virStreamFinish(priv->handle) < 0) - g_critical("cannot finish stream"); + if (virStreamFinish(priv->handle) < 0) { + virErrorPtr verr = virGetLastError(); + g_critical("cannot finish stream: %s", verr->message); + }
virStreamFree(priv->handle); }
ACK Michal