On 02/05/2018 10:41 AM, Jiri Denemark wrote:
On Fri, Feb 02, 2018 at 17:40:11 -0500, John Ferlan wrote:
Define the qemuMonitorDumpStats as a new job JobStatsType to handle being able to get memory dump statistics. For now do nothing with the new TYPE_MEMDUMP.
Reviewed-by: Jiri Denemark <jdenemar@redhat.com> Signed-off-by: John Ferlan <jferlan@redhat.com>
Aren't new tags usually added to the end of the commit message? In other words:
Signed-off-by: John Ferlan <jferlan@redhat.com> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
I don't know if it makes any difference (probably not), though.
Jirka
I thought that was strange too - figuring it was just me... Then I looked at a few other recent commits (see 1b9fe756) and figured that's just how the S-o-b seems to work - it gets tacked onto the end. Not sure what would happen if I modified things to have S-o-b followed by R-b... Would git be smart enough to not tack another one or would there be a 2nd S-o-b also appended. John