Re: [libvirt] [PATCH 3/3] conf: restrict where dmi-to-pci-bridge can be connected

libvirt had allowed a dmi-to-pci-bridge to be plugged in anywhere a normal PCIe endpoint can be connected, but this is wrong - it will only work if it's plugged into pcie-root (the PCIe root complex) or a pcie-expander-bus (the qemu device pxb-pcie). This patch adjusts the connection flags accordingly.   Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1363648

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index d594836..933f9be 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1631,6 +1631,22 @@ mymain(void)               QEMU_CAPS_PCI_MULTIFUNCTION, QEMU_CAPS_ICH9_USB_EHCI1,               QEMU_CAPS_DEVICE_VIDEO_PRIMARY,               QEMU_CAPS_VGA_QXL, QEMU_CAPS_DEVICE_QXL); +    DO_TEST_PARSE_ERROR("q35-dmi-bad-address1", +            QEMU_CAPS_DEVICE_PCI_BRIDGE, +            QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, +            QEMU_CAPS_DEVICE_IOH3420, +            QEMU_CAPS_ICH9_AHCI, +            QEMU_CAPS_PCI_MULTIFUNCTION, QEMU_CAPS_ICH9_USB_EHCI1, +            QEMU_CAPS_DEVICE_VIDEO_PRIMARY, +            QEMU_CAPS_VGA_QXL, QEMU_CAPS_DEVICE_QXL); +    DO_TEST_PARSE_ERROR("q35-dmi-bad-address2", +            QEMU_CAPS_DEVICE_PCI_BRIDGE, +            QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, +            QEMU_CAPS_DEVICE_IOH3420, +            QEMU_CAPS_ICH9_AHCI, +            QEMU_CAPS_PCI_MULTIFUNCTION, QEMU_CAPS_ICH9_USB_EHCI1, +            QEMU_CAPS_DEVICE_VIDEO_PRIMARY, +            QEMU_CAPS_VGA_QXL, QEMU_CAPS_DEVICE_QXL);       DO_TEST("q35-pm-disable",               QEMU_CAPS_DEVICE_PCI_BRIDGE,               QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE, QEMU_CAPS_ICH9_AHCI,