On Tue, Jul 30, 2013 at 12:57:36PM +0200, Jiri Denemark wrote:
On Tue, Jul 30, 2013 at 11:27:58 +0100, Daniel Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The python/tests directory contains a number of so called
> "tests" for the python API. These are all hardcoded to
> look for Xen and cannot be run in any automated fashion,
> and no one is ever manually running them. Given that they
> don't meaningully contribute to the test coverage, delete
> them.
>
> For some reason these tests were also copied into the
> filesystem as part of 'make install'. The change to the
> RPM in commit 3347a4203278ec93d7b0ceb88b5ed10e4f14765c
> caused a build failure, since it removed the code which
> deleted these installed tests.
>
> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com>
ACK
I'm fine seeing them go :-)
ACK too
Daniel
--
Daniel Veillard | Open Source and Standards, Red Hat
veillard(a)redhat.com | libxml Gnome XML XSLT toolkit
http://xmlsoft.org/
http://veillard.com/ | virtualization library
http://libvirt.org/