Re: [libvirt] [PATCH] qemu: Fix error code when attaching existing device

On 12/04/12 11:19, Jiri Denemark wrote:

An attempt to attach device that is already attached to a domain results in the following error:

virsh # attach-device rhel6 pci2 --persistent error: Failed to attach device from pci2 error: invalid argument: device is already in the domain configuration

The "invalid argument" error code looks wrong, we usually use "operation invalid" when the action cannot be done in current state. --- src/qemu/qemu_driver.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)

ACK Peter