Re: [libvirt] [PATCH 3/3] Stop accessing driver->caps directly in QEMU driver
On Thu, Feb 07, 2013 at 11:47:41AM +0100, Jiri Denemark wrote:
On Wed, Feb 06, 2013 at 11:54:51 +0000, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>
> The 'driver->caps' pointer can be changed on the fly. Accessing
> it currently requires the global driver lock. Isolate this
> access in a single helper, so a future patch can relax the
> locking constraints.
...
I checked that no direct access to driver->caps remained.
There are quite a few places where virQEMUDriverGetCapabilities is
called on an unlocked driver but that's not your fault. The bug has been
there even for years in some cases. Anyway, I guess one of your next
series will fix all these issues by changing the way we use qemu driver
lock.
Yeah, there are loads of bugs in this area :-(
I've got 4 more patches queued and then the really nice one - deleting
nearly every single case of qemuDriverLock/Unlock :-)
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|