Re: [libvirt] [PATCH] m4: Improve portability for non-bash shells

On Sat, 2019-10-19 at 11:46 +0000, Maya Rashish wrote:

= and == are both operators to test for string equality in bash, but only = is required by POSIX.

Signed-off-by: Maya Rashish <coypu@sdf.org> --- m4/virt-nls.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Welp, I'm surprised nobody noticed until now: the code in question has been merged more than a year ago. Anyway, your fix is correct, so Reviewed-by: Andrea Bolognani <abologna@redhat.com> and pushed. Congratulation on your first libvirt contribution! :) -- Andrea Bolognani / Red Hat / Virtualization