Re: [libvirt] Bump tar format?
On Wed, Jul 22, 2015 at 05:49:20PM +0200, Andrea Bolognani wrote:
On Wed, 2015-07-22 at 15:58 +0100, Daniel P. Berrange wrote:
>
> > Any suggestions on how to proceed?
>
> We've hit this many times before and always just shorten the file
> names in GIT to avoid it.
>
> Really we could do with adding a check for filename length to
> make check to avoid this again.
Might not be trivial, as limits are apparently different for symbolic
links and regular files, nevermind the fact that very similar versions
of tar (eg. Fedora 22 and Fedora rawhide) don't behave the same.
If we assume 'libvirt-X.Y.Z/' (with double-digits for each version field)
as a prefix, that's upto 17 characters consumed. With a limit of 100 chars
for symlinks, we should simply make sure all our file names are 83 characters
or less
$ ./build-aux/vc-list-files | perl -e 'while (<>) { die "filename $_ too
long" if length($_) > 83 }'
filename
tests/cputestdata/x86-host-Haswell-noTSX+Haswell-noTSX,haswell,Haswell-noTSX-result.xml
too long at -e line 1, <> line 1280.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|