Re: [libvirt] pvpanic plans?
On Thu, Oct 31, 2013 at 08:32:43AM -0600, Eric Blake wrote:
On 10/31/2013 08:30 AM, Michael S. Tsirkin wrote:
> On Thu, Oct 24, 2013 at 10:39:03AM +0800, Hu Tao wrote:
>> Hi All,
>>
>> I know it's been a long time since this thread. But qemu 1.7 is
>> releasing, do you have any consensus on this?
>>
>> Thanks.
>
>
> I think the biggest issue is the new PANICKED state.
> Guests already have simple ways to halt the CPU,
> and actually do. I think a new state was a mistake.
> So how about the following? Does it break anything?
> (Untested).
>
> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com>
>
> diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
> index 226e298..2055afc 100644
> --- a/hw/misc/pvpanic.c
> +++ b/hw/misc/pvpanic.c
> @@ -51,7 +51,6 @@ static void handle_event(int event)
>
> if (event & PVPANIC_PANICKED) {
> panicked_mon_event("pause");
> - vm_stop(RUN_STATE_GUEST_PANICKED);
Don't you still need to halt the guest on a panic event, for management
to have a chance to choose what to do about the panic?
Guest can just call hlt to do this. Most guests do this on a panic
already.
I'm suspecting
this patch does break things.
http://xkcd.com/1172/
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org