Re: [libvirt] [PATCH] util: don't free dmidecode path string before printing it

On Tue, Sep 18, 2012 at 17:33:57 -0600, Eric Blake wrote: > On 09/18/2012 04:57 AM, Ján Tomko wrote: >> The path was freed before printing the error message, resulting in: >> error : virSysinfoRead:773 : internal error Failed to execute command >> (null) >> --- >> src/util/sysinfo.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > While this fixes the bug, it is still a less the useful error. > virCommandRun() already gives a better error message and we are > overriding it. I'd prefer: >

Indeed, ACK to this version.