Re: [libvirt] [PATCHv2 3/8] audit: also audit cgroup controller path

> + virCgroupPathOfController(cgroup, VIR_CGROUP_CONTROLLER_DEVICES, > + NULL, &controller); > + > + if (!(detail = virAuditEncode("cgroup", VIR_AUDIT_STR(controller)))) { > + VIR_WARN0("OOM while encoding audit message"); > + goto cleanup; > + } > + > VIR_AUDIT(VIR_AUDIT_RECORD_RESOURCE, success, > - "resrc=cgroup reason=%s %s uuid=%s class=%s", > - reason, vmname, uuidstr, extra); > + "resrc=cgroup reason=%s %s uuid=%s %s class=%s", > + reason, vmname, uuidstr, detail, extra); I think perhaps we should make a better effort to output the audit event if creating 'detail' fails. eg remove the goto cleanup and do 'detail ? detail : "cgroup=?"' here