On Tue, Jan 22, 2008 at 04:28:12PM -0500, Daniel Veillard wrote:
On Tue, Jan 22, 2008 at 07:21:41PM +0100, Jim Meyering wrote:
"Daniel P. Berrange" <berrange@redhat.com> wrote: ...
Index: configure.in =================================================================== RCS file: /data/cvs/libvirt/configure.in,v retrieving revision 1.121 diff -u -p -r1.121 configure.in --- configure.in 19 Jan 2008 18:36:01 -0000 1.121 +++ configure.in 22 Jan 2008 17:21:27 -0000 ... -if test "z$with_libxml" = "zno" ; then +if test "$with_libxml" = "no" ; then
It's good to leave some kind of prefix on tested values like that, since the $with_libxml value is user-settable. I.e., with your change, --with-libxml=-lt causes a syntax error in the configure script:
./configure: line 27674: test: -z: integer expression expected
Oh, that's why, I always wondered why people had that strange habit of adding a prefix, good to know !
+1 for the patch too,
I put those extra 'x' back into the tests - and added some more which were already msssing. I broke some of the lines to be under 80, but it wasn't pratical to fix all of them. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|