Re: [libvirt] [PATCH 10/11] qemu: bulk stats: implement block group
----- Original Message -----
From: "Li Wei" <lw(a)cn.fujitsu.com>
To: "Francesco Romani" <fromani(a)redhat.com>, libvir-list(a)redhat.com
Sent: Monday, September 1, 2014 7:32:37 AM
Subject: Re: [libvirt] [PATCH 10/11] qemu: bulk stats: implement block group
Hi Francesco,
I notice your patchset is much complete than mine which only focus on
VIR_DOMAIN_STATS_BLOCK[1], but it seems your patch implement block stats
query in a per-block style, this should be a bottleneck when there are
a lot of block devices in a domain.
Could you implement it in a bulk style? so we just need only one qmp-command
for each domain.
[1]: https://www.redhat.com/archives/libvir-list/2014-August/msg01497.html
Hi Li Wei,
Thanks for pointing this out. Performance is surely a major concern of mine,
then I'll improve my patch in the direction you outlined.
I read your patch (actually I like some parts of your patch more than mine!)
but I must somehow missed that.
I'll wait for more reviews before to resubmit.
Thanks and bests,
--
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani