Re: [libvirt] [PATCH v4 22/23] security_selinux: Move transaction handling up one level
On 09/10/2018 05:36 AM, Michal Privoznik wrote:
So far the whole transaction handling is done
virSecuritySELinuxSetFileconHelper(). This needs to change for
the sake of security label remembering and locking. Otherwise we
would be locking a path when only appending it to transaction
list and not when actually relabelling it.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/security/security_selinux.c | 35 ++++++++++++++++++++++++++---------
1 file changed, 26 insertions(+), 9 deletions(-)
I shall note only that you didn't follow what you did for DAC with
regard to copying around the comment:
/* Be aware that this function might run in a separate process.
* Therefore, any driver state changes would be thrown away. */
Beyond that - this is light years cleaner than DAC, thankfully because
my wife will be not be happy if I go on much longer ;-)
I trust you can move comments appropriately...
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John