On Thu, 18 Dec 2025 15:45:10 +0800 Zhao Liu <zhao1.liu@intel.com> wrote:
On Wed, Dec 17, 2025 at 03:55:30PM +0100, Igor Mammedov wrote:
Date: Wed, 17 Dec 2025 15:55:30 +0100 From: Igor Mammedov <imammedo@redhat.com> Subject: Re: [PATCH v5 16/28] hw/i386: Remove linuxboot.bin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.51; x86_64-redhat-linux-gnu)
On Wed, 3 Dec 2025 00:28:23 +0800 Zhao Liu <zhao1.liu@intel.com> wrote:
From: Philippe Mathieu-Daudé <philmd@linaro.org>
All machines now use the linuxboot_dma.bin binary, so it's safe to remove the non-DMA version (linuxboot.bin).
after applying this patch:
git grep linuxboot.bin
option_rom[nb_option_roms].bootindex = 0; option_rom[nb_option_roms].name = "linuxboot.bin"; if (fw_cfg_dma_enabled(fw_cfg)) { option_rom[nb_option_roms].name = "linuxboot_dma.bin"; }
perhaps it should be fixed in previous patch
Thanks, I find this change was included in the previous patch (patch 15).
Yep, sorry for confusion. /I forgot to apply #15, hence it led to a stray linuxboot.bin/
And I have a GitLab branch and hopefully it could help apply and review:
https://gitlab.com/zhao.liu/qemu/-/commits/remove-2.6-and-2.7-pc-v5-11-26-20...
Regards, Zhao