On 05/13/2016 02:13 PM, Roman Bogorodskiy wrote:
Fabian Freyer wrote:
This implements virConnectGetType for the bhyve driver.
--- src/bhyve/bhyve_driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 4fc504e..a853e94 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1508,6 +1508,15 @@ bhyveDomainHasManagedSaveImage(virDomainPtr domain, unsigned int flags) return ret; }
+static const char * +bhyveConnectGetType(virConnectPtr conn ATTRIBUTE_UNUSED)
ATTRIBUTE_UNUSED is not needed here.
ATTRIBUTED_UNUSED tells the compiler not to throw a warning if the parameter ('conn' in this case) isn't used in the function. So if the function _does_ use the parameter, the annotation is incorrect. That means that if you grabbed that pattern from any other GetType implementations, the ATTRIBUTE_UNUSED usage there may be incorrect as well. So more opportunity for patches :) - Cole