Re: [Libvir] [PATCH][RFC] libvirt ldoms support
On Thu, Apr 10, 2008 at 08:05:11PM +0100, John Levon wrote:
On Thu, Apr 10, 2008 at 07:54:08PM +0100, Daniel P. Berrange wrote:
> If the LDoms code is to be merged into libvirt, IMHO, it has to
> be 100% compliant with the defined libvirt XML format.
Or extend it, surely?
Well there are two separate scenarios here. Some of the elements in the
the LDoms XML are expressing concepts for which there is no existing
libvirt XML format defined. If they are suitably generic that they can
be applied to other non-LDoms drivers then we can add them to the official
libvirt XML format, otherwise they'll have to be changed to be suitably
flexible. Other XML elements in the LDoms XML are representing things
that are already represented in libvirt, but using a different format.
The key is that we need an XML format that has consistent representation
across all drivers. IMHO, the LDoms format as illustrated earlier in this
thread is very far away from being suitable for inclusion in libvirt.
(I know I've whined before but it would be awfully nice to have
some-one
step up and update the schema: then it would be possible to insist all
such changes update the schema too.)
Yes, but that doesn't excuse developing these extensions in private and then
just dumping them on the list as a final solution. The only practical way to
develop extensions to the XML format is to have upfront discussions on the
proposal prior to implementation so all stakeholder have the chance to
discuss the propsals.
Dan.
--
|: Red Hat, Engineering, Boston -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|