Re: [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

On 09/19/2016 02:42 PM, Eduardo Habkost wrote: > Add a new optional field to query-cpu-definitions schema: > "unavailable-features". It will contain a list of QOM properties > that prevent the CPU model from running in the current host. > > Cc: David Hildenbrand <dahi(a)linux.vnet.ibm.com&gt; > Cc: Michael Mueller <mimu(a)linux.vnet.ibm.com&gt; > Cc: Christian Borntraeger <borntraeger(a)de.ibm.com&gt; > Cc: Cornelia Huck <cornelia.huck(a)de.ibm.com&gt; > Cc: Jiri Denemark <jdenemar(a)redhat.com&gt; > Cc: libvir-list(a)redhat.com > Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com&gt; > --- > +++ b/qapi-schema.json > @@ -3111,10 +3111,31 @@ > # QEMU version, machine type, machine options and accelerator options. > # A static model is always migration-safe. (since 2.8) > # > +# @unavailable-features: #optional List of properties that prevent > +# the CPU model from running in the current > +# host. (since 2.7) We've missed 2.7; this should probably be 2.8. Otherwise reads okay to me; Reviewed-by: Eric Blake <eblake(a)redhat.com&gt;