Re: [libvirt] [PATCH] spec: Cat test-suite.log if make check fails
On 07/29/2013 09:44 AM, Jiri Denemark wrote:
Current automake enables parallel test by default, which means test
details are only logged in test-suite.log and not printed to stderr.
This patch makes test failures directly visible in RPM build logs even
when parallel tests are turned on.
---
libvirt.spec.in | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
ACK; worth having in 1.1.1.
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 81101e8..a3a831f 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1482,7 +1482,11 @@ do
printf '#!/bin/sh\nexit 0\n' > $i
chmod +x $i
done
-make check
+if ! make check VIR_TEST_DEBUG=1
+then
+ cat test-suite.log || true
+ exit 1
+fi
%if %{with_libvirtd}
%pre daemon
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)