On Wed, Jul 18, 2012 at 05:32:23PM +0100, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
When sending SIGHUP to libvirtd, it will trigger the virStateDriver reload operation. This is intended to reload the configuration files for guests. For unknown historical reasons this is also triggering autostart of all guests. Autostart is generally expected to be something that happens on OS startup. Starting VMs on SIGHUP will violate that expectation and potentially cause dangerous scenarios if the admin has explicitly shutdown a misbehaving VM that has been marked as autostart
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_driver.c | 2 -- src/qemu/qemu_driver.c | 2 -- src/uml/uml_driver.c | 2 -- 3 files changed, 6 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 2d931db..c341125 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -2750,8 +2750,6 @@ lxcReload(void) { lxcNotifyLoadDomain, lxc_driver); lxcDriverUnlock(lxc_driver);
- lxcAutostartConfigs(lxc_driver); - return 0; }
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d3988b8..46000f4 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -805,8 +805,6 @@ qemudReload(void) { qemudNotifyLoadDomain, qemu_driver); qemuDriverUnlock(qemu_driver);
- qemuAutostartDomains(qemu_driver); - return 0; }
diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index 098ee7b..b8d0ab7 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -553,8 +553,6 @@ umlReload(void) { umlNotifyLoadDomain, uml_driver); umlDriverUnlock(uml_driver);
- umlAutostartConfigs(uml_driver); - return 0; }
Okay, in any case it's a bug. The chances to find out why that was introduced in the first place is more likely if we push the fix and test. ACK Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/