On Wed, Sep 09, 2015 at 10:16:33 +0200, Michal Privoznik wrote:
On 08.09.2015 14:10, Peter Krempa wrote:
> On Wed, Sep 02, 2015 at 17:58:19 +0200, Michal Privoznik wrote:
>> From: Lin Ma <lma(a)suse.com>
>>
>> Format & output more detailed information about networked source
>>
>> e.g: The output without the patch:
>> $ virsh domblklist $DOMAIN --details
>> Type Device Target Source
>> ------------------------------------------------
>> network disk vda test-pool/image
>> network disk vdb iqn.2015-08.org.example:sn01/0
>> network disk vdc /image.raw
>> network disk vdd -
>> network disk vde -
>> network disk vdf image1
>> network disk vdg test-volume/image.raw
>>
>> The output with the patch:
>> $ virsh domblklist $DOMAIN --details
>> Type Device Target Source
>> ------------------------------------------------
>> network disk vda
rbd://monitor1.example.org:6321/test-pool/image
>
> One other thing to note is that RBD volumes may have multiple hosts,
> which is not taken into account by the above format ...
>
>> network disk vdb
iscsi://192.168.124.200:3260/iqn.2015-08.org.example:sn01/0
>> network disk vdc
http://192.168.124.200:80/image.raw
>> network disk vdd nbd+unix:///var/run/nbdsock
>> network disk vde nbd://192.168.124.200:12345
>> network disk vdf sheepdog://192.168.124.200:6000/image1
>> network disk vdg
gluster://192.168.124.200/test-volume/image.raw
>
> ... and gluster volumes will possibly have multiple sources too.
Do you have any bright idea how to express that? E.g. something like:
gluster://{hostA, hostB, hostC}/test-volume/image.raw
rbd://{hostD, hostE}/test-pool/image
Gluster and RBD also needs to expose host:port combinations possibly.
can work?
I'd refrain from strings formatted as URIs or anything hypervisor
specific (eg QEMU source string for RBD). I'd rather see a human
formatted string since this is a human readable output:
"hosts: host1.example.com:123 host2.example.com:345 path:
test-volume/image.raw"
Scripts definitely have better time parsing the XML here.
Peter